impl HttpError::new_boxed to provide user with ability to ctor from already boxed error#789
Merged
Merged
Conversation
…lready boxed error
DoumanAsh
changed the title
alamb
approved these changes
Jul 8, 2026
alamb
left a comment
alamb
left a comment
Contributor
There was a problem hiding this comment.
Looks like a nice improvement to me -- thank you @DoumanAsh
alamb
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None, it is minor improvement to API
Rationale for this change
I would like to be able to created HttpError from already boxed error for my alternative HTTP client implementation
Otherwise I need to wrap boxed error into new type
What changes are included in this PR?
Introduces new method to HttpError to create error from boxed
dyn std::error::ErrorAre there any user-facing changes?
New public method on
HttpErrorNo breaking changes